-
Notifications
You must be signed in to change notification settings - Fork 290
Invoice Details for "Unit Cost Surcharge" #5280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invoice Details for "Unit Cost Surcharge" #5280
Conversation
...s/W1/Subscription Billing/Demo Data/Demo Data/2.Master Data/CreateSubBillGenSett.Codeunit.al
Outdated
Show resolved
Hide resolved
samra-singhammer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Miljan, I've added couple of comments and questions. Please review them.
src/Apps/W1/Subscription Billing/App/Billing/Codeunits/SubContractBillingPrintout.Codeunit.al
Outdated
Show resolved
Hide resolved
...W1/Subscription Billing/App/Usage Based Billing/Codeunits/CreateUsageDataBilling.Codeunit.al
Show resolved
Hide resolved
...ubscription Billing/App/Usage Based Billing/Codeunits/GenericConnectorProcessing.Codeunit.al
Show resolved
Hide resolved
...W1/Subscription Billing/App/Usage Based Billing/Codeunits/CreateUsageDataBilling.Codeunit.al
Outdated
Show resolved
Hide resolved
...s/W1/Subscription Billing/Demo Data/Demo Data/2.Master Data/CreateSubBillGenSett.Codeunit.al
Outdated
Show resolved
Hide resolved
src/Apps/W1/Subscription Billing/Test/UBB/UsageBasedBillingTest.Codeunit.al
Show resolved
Hide resolved
|
@miljance @samra-singhammer Please check the build errors |
I took a look and cannot identify what is the reason. I have looked at pipelines for each localization and the only thing I find is: |
@miljance you have to take a look at the top: The only issue that I found that is relatd to UBB is in Build Apps for W1 clean: |
Thanks, that is what I was missing. It seems the branch is conflicting with one of the previous merges. Will address it now. |
…ceDetailsForUsageDataScenarios
AndersLarsenMicrosoft
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all good
2ba50a7
|
Conflicts resolved |
|
@miljance, let's get this one on the road. Seems like build is failing with: |
That’s what happens when you poke code you should’ve just quietly walked past. Fixed. |
|
@miljance, a few more things for you to fix: |
fixed |
AndersLarsenMicrosoft
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
,
AndersLarsenMicrosoft
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.


Summary
⚠️ Note: This pull request requires a technical code review. Please hold off on approval until the technical review is completed by @samra-singhammer.
Work Item(s)
Fixes #4485
Fixes AB#614158